Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add destination_expiration_time property to copy job #1277

Merged
merged 6 commits into from
Jun 17, 2022

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Jun 15, 2022

add destination_expiration_time property to copy job config

Fixes #1216 🦕

@steffnay steffnay requested a review from a team June 15, 2022 01:24
@steffnay steffnay requested a review from a team as a code owner June 15, 2022 01:24
@steffnay steffnay requested a review from GaoleMeng June 15, 2022 01:24
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jun 15, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Jun 15, 2022
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added minor observations

google/cloud/bigquery/job/copy_.py Outdated Show resolved Hide resolved
google/cloud/bigquery/job/copy_.py Outdated Show resolved Hide resolved
steffnay and others added 2 commits June 16, 2022 11:56
@steffnay steffnay merged commit 728b07c into googleapis:main Jun 17, 2022
waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull request Jul 20, 2022
…s#1277)

* feat: add destination_expiration_time property to copy job

* update test

* refactor test

* remove unused import

* Update google/cloud/bigquery/job/copy_.py

Co-authored-by: Anthonios Partheniou <[email protected]>

* Update google/cloud/bigquery/job/copy_.py

Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: Anthonios Partheniou <[email protected]>
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
…s#1277)

* feat: add destination_expiration_time property to copy job

* update test

* refactor test

* remove unused import

* Update google/cloud/bigquery/job/copy_.py

Co-authored-by: Anthonios Partheniou <[email protected]>

* Update google/cloud/bigquery/job/copy_.py

Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing destinationExpirationTime while creating table snapshot
2 participants