Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add a sample for max commit delays #1993

Merged
merged 17 commits into from
Mar 8, 2024
Merged

feat(spanner): add a sample for max commit delays #1993

merged 17 commits into from
Mar 8, 2024

Conversation

nginsberg-google
Copy link
Contributor

This PR adds a sample and test for max commit delays.

@nginsberg-google nginsberg-google requested review from a team as code owners February 9, 2024 02:03
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Feb 9, 2024 •
edited

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 9, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Feb 9, 2024 •
edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. labels Feb 9, 2024
surbhigarg92
surbhigarg92 requested changes Feb 9, 2024
View reviewed changes
samples/max-commit-delay.js Outdated Show resolved Hide resolved
samples/max-commit-delay.js Show resolved Hide resolved
nginsberg-google
nginsberg-google commented Feb 10, 2024
View reviewed changes
Copy link
Contributor Author

@nginsberg-google nginsberg-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed the comments. PTAL.

samples/max-commit-delay.js Show resolved Hide resolved
samples/max-commit-delay.js Outdated Show resolved Hide resolved
@surbhigarg92 surbhigarg92 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 14, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

@surbhigarg92 surbhigarg92 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 8, 2024
@surbhigarg92 surbhigarg92 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 8, 2024
@surbhigarg92 surbhigarg92 merged commit 91c7204 into googleapis:main Mar 8, 2024
16 checks passed
@release-please release-please bot mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nginsberg-google @surbhigarg92 @yoshi-kokoro @harshachinta