Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated google-gax required for TPC #1882

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Feb 5, 2024

The CI for TPC support worked because it installs dependencies from scratch every time. However, a newer gax is required for the TPC stuff to compile. This is to avoid any surprises for people who incrementally npm install.

@feywind feywind requested review from a team as code owners February 5, 2024 19:57
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Feb 5, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 5, 2024
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2024
@feywind feywind merged commit 1445856 into googleapis:main Feb 5, 2024
15 checks passed
@feywind feywind deleted the tpc-support branch February 5, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants