Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid zalgo when calling down to publish messages #1710

Merged
merged 4 commits into from
Apr 26, 2023
Merged

fix: avoid zalgo when calling down to publish messages #1710

merged 4 commits into from
Apr 26, 2023

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Apr 13, 2023

I just noticed this when looking at other things - the publish() call will almost certainly call the callback async.

@feywind feywind requested review from a team as code owners April 13, 2023 19:24
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 13, 2023
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Apr 13, 2023
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2023
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2023
@feywind feywind merged commit dedae1e into googleapis:main Apr 26, 2023
12 checks passed
@feywind feywind deleted the publish-zalgo branch April 26, 2023 19:06
@release-please release-please bot mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@feywind @bcoe