Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add CLOUDSDK_PYTHON env var to environment tests #1385

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix: add CLOUDSDK_PYTHON env var to environment tests #1385

merged 1 commit into from
Dec 16, 2022

Conversation

daniel-sanche
Copy link
Contributor

Fixes failing Kubernetes environment tests by adding the CLOUDSDK_PYTHON environment variable

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Dec 16, 2022 •
edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 16, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/environment.sh - .kokoro files are templated and should be updated in synthtool

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Dec 16, 2022
@daniel-sanche daniel-sanche changed the title [DRAFT] fix: add CLOUDSDK_PYTHON to environment tests fix: add CLOUDSDK_PYTHON to environment tests Dec 16, 2022
@daniel-sanche daniel-sanche marked this pull request as ready for review December 16, 2022 22:24
@daniel-sanche daniel-sanche requested review from a team as code owners December 16, 2022 22:24
@losalex losalex changed the title fix: add CLOUDSDK_PYTHON to environment tests fix: add CLOUDSDK_PYTHON env var to environment tests Dec 16, 2022
@losalex losalex added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 16, 2022
@losalex losalex added the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8ac3e6b into main Dec 16, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the daniel-sanche-env-test-patch branch December 16, 2022 22:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2022
@release-please release-please bot mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/nodejs-logging API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniel-sanche @losalex