Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Test is less restrictive to allow changes #1160

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

danieljbruce
Copy link
Contributor

Sometimes cluster metadata returned changes slightly and this causes tests to fail. We want to make sure that these tests only check for what really needs to be there.

@danieljbruce danieljbruce requested review from a team as code owners September 16, 2022 14:33
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 16, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 16, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Sep 16, 2022
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2022
Copy link

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieljbruce danieljbruce merged commit 7d05b96 into googleapis:main Sep 19, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 26, 2022
🤖 I have created a release *beep* *boop*
---


## [4.0.5](v4.0.4...v4.0.5) (2022-09-23)


### Bug Fixes

* Test is less restrictive to allow changes ([#1160](#1160)) ([7d05b96](7d05b96))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants