Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-bigtable
base: v4.4.0
Choose a base ref
...
head repository: googleapis/nodejs-bigtable
compare: v4.5.0
Choose a head ref
  • 6 commits
  • 14 files changed
  • 5 contributors

Commits on Mar 6, 2023

  1. chore(testproxy): fix close generated (v2) clients (#1249)

    Tests for closing the client are failing since a new client object is
    created on every operation that uses the generated (v2) layer. This
    changeset fixes it by moving the v2 client creation to
    `testproxy/services/create-client.js` alongside the veneer client
    creation.
    
    Every command using the v2 layer is updated to read the client from the
    client map instead of creating a new instance.
    
    Three previosly failing tests are now passing with this fix:
    - TestCheckAndMutateRow_Generic_CloseClient
    - TestMutateRow_Generic_CloseClient
    - TestReadModifyWriteRow_Generic_CloseClient
    ruyadorno committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    44fab5c View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. feat: Add npm run compile to the testproxy command (#1258)

    * Add npm run compile to the testproxy command
    
    The test proxy references the compiled client library code. Every time the test proxy is run, we want it to reflect the source code so that as we develop we don’t get confused about what gets observed.
    
    * feat: Add npm run compile to the testproxy command
    danieljbruce committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    52c06a2 View commit details
    Browse the repository at this point in the history
  2. fix: Always set the retry attempt to 0 for now (#1251)

    * Always set the retry attempt to 0 for now
    
    If the retry attempt is greater than 1 then a library called retryRequest creates a large delay. If we force the retry count to be 0 then we skip this delay and the requests run in the required timeline.
    
    * fix: Always set the retry attempt to 0 for now
    danieljbruce committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    5ee6f19 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. chore: store nodejs build artifacts in placer (#1262)

    Source-Link: googleapis/synthtool@3602660
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e6d785d6de3cab027f6213d95ccedab4cab3811b0d3172b78db2216faa182e32
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    gcf-owl-bot[bot] and gcf-owl-bot[bot] committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    d6fc67c View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Increases the maximum retries to 10 (#1261)

    The client should still have the opportunity to retry after only a few retriable errors.
    danieljbruce committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    23ec482 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. chore(main): release 4.5.0 (#1259)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c80e9f6 View commit details
    Browse the repository at this point in the history