chore(toolbox-core): Use Toolbox server dev build for integration tests #298
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000adc to
3212d63
Compare
fa6b4f4 to
ca766a3
Compare
d6a153e to
57aeeb2
Compare
ca766a3 to
2ccb261
Compare
1c598a4 to
90f7472
Compare
2ccb261 to
9bee6e5
Compare
90f7472 to
7e38892
Compare
c66ade4 to
f811574
Compare
kurtisvg
previously approved these changes
Jul 2, 2025
f811574 to
3287116
Compare
3287116 to
1a0b5e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the integration tests to use a dev build of the toolbox server from the
mainbranch.Currently, integration tests are conducted against a released version of the toolbox server. This poses a challenge when SDK and server features, such as optional parameters, are developed and released concurrently. In such scenarios, integration tests for the SDK will fail as the corresponding server-side support is absent in the released version.
To address this, this change modifies the server download for integration tests to pull from the GCS bucket for toolbox dev builds, specifically from the
mainbranch. This ensures that the SDK is tested against the latest server version, which should ideally be stable and backward-compatible.Flexibility in Versioning
For situations where new SDK features do not have a dependency on server-side changes, the
TOOLBOX_VERSIONand the newly introducedTOOLBOX_BUCKETenv vars in theintegration.cloudbuild.yamlconfig can be adjusted. This allows for switching back to a specific released version of the toolbox server for integration testing if needed.Note
This PR removes the automatic
vprefix from the version when constructing the blob download URL. Consequently, if you need to test against a released version (e.g.,0.8.0), theTOOLBOX_VERSIONmust be set tov0.8.0. This change accommodates version values that do not have a v prefix, such asmain.Note
The integration tests would currently fail due to a known issue with the optional parameters implementation with the server dev build [#771]