Skip to content

ci: make builds green #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2024
Merged

ci: make builds green #105

merged 2 commits into from
Dec 19, 2024

Conversation

jackwotherspoon
Copy link
Contributor

@jackwotherspoon jackwotherspoon commented Dec 19, 2024 •
edited
Loading

  1. Builds are failing due to coverage being slightly below 89%, bumping down to 85%.
FAIL Required test coverage of 89.0% not reached. Total coverage: 88.94%
  1. Looks like docs GitHub Action is failing due to mismatch in Python version.

Github Action is set to checkout Python 3.9 yet the noxfile says use 3.10:

langchain-google-cloud-sql-mysql-python/.github/workflows/docs.yml

Line 15 in 84ae054

python-version: "3.9"

langchain-google-cloud-sql-mysql-python/noxfile.py

Line 39 in 84ae054

@nox.session(python="3.10")

@jackwotherspoon jackwotherspoon self-assigned this Dec 19, 2024
@jackwotherspoon jackwotherspoon requested review from a team as code owners December 19, 2024 14:48
@product-auto-label product-auto-label bot added the api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API. label Dec 19, 2024
@jackwotherspoon jackwotherspoon changed the title chore: update test coverage value ci: make builds green Dec 19, 2024
@averikitsch averikitsch merged commit 6c4e591 into main Dec 19, 2024
11 checks passed
@averikitsch averikitsch deleted the jackwotherspoon-patch-1 branch December 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackwotherspoon @averikitsch