Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clirr build #3000

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: clirr build #3000

merged 1 commit into from
Apr 3, 2024

Conversation

rahul2393
Copy link
Contributor

  1. Executor framework changes skipped in clirr checks
  2. Added exception for partition methods in admin class

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

…ception for partition methods in admin class
@rahul2393 rahul2393 requested review from a team as code owners April 3, 2024 09:44
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Apr 3, 2024
@rahul2393 rahul2393 requested a review from arpan14 April 3, 2024 09:44
@arpan14 arpan14 merged commit c2d8e95 into main Apr 3, 2024
27 of 28 checks passed
@arpan14 arpan14 deleted the fix-clirr-issues branch April 3, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants