Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: renaming the CreateUnwrappedPushSubscription File #1794

Merged
merged 5 commits into from
Oct 31, 2023
Merged

docs: renaming the CreateUnwrappedPushSubscription File #1794

merged 5 commits into from
Oct 31, 2023

Conversation

maitrimangal
Copy link
Member

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 26, 2023 •
edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 26, 2023
@snippet-bot
Copy link

snippet-bot bot commented Oct 26, 2023 •
edited

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Oct 26, 2023
@maitrimangal maitrimangal changed the title renaming the CreateUnwrappedPushSubscription File docs: renaming the CreateUnwrappedPushSubscription File Oct 26, 2023
@maitrimangal maitrimangal added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2023
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners October 27, 2023 19:38
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 27, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Oct 30, 2023
@maitrimangal maitrimangal added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 30, 2023
@maitrimangal maitrimangal merged commit 3264290 into googleapis:main Oct 31, 2023
20 checks passed
@release-please release-please bot mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@kamalaboulhosn kamalaboulhosn Awaiting requested review from kamalaboulhosn

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maitrimangal @hongalex