Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Receipt modack #1540

Merged
merged 69 commits into from
Aug 24, 2023
Merged

feat: Receipt modack #1540

merged 69 commits into from
Aug 24, 2023

Conversation

maitrimangal
Copy link
Member

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1523 ☕️

@maitrimangal maitrimangal requested a review from a team as a code owner April 3, 2023 13:32
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Apr 3, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 18, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Apr 18, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 19, 2023
@maitrimangal maitrimangal added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2023
hannahrogers-google
hannahrogers-google reviewed Aug 22, 2023
View reviewed changes
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated Show resolved Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated Show resolved Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated Show resolved Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated Show resolved Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated Show resolved Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java Outdated Show resolved Hide resolved
google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/MessageMatcher.java Outdated Show resolved Hide resolved
@maitrimangal maitrimangal added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2023
@maitrimangal maitrimangal added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2023
@hannahrogers-google hannahrogers-google removed the request for review from kamalaboulhosn August 24, 2023 20:05
@maitrimangal maitrimangal merged commit 74d8da9 into googleapis:main Aug 24, 2023
20 checks passed
@release-please release-please bot mentioned this pull request Aug 24, 2023
Merged
@Sourc Sourc mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

@kamalaboulhosn kamalaboulhosn kamalaboulhosn left review comments

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exactly Once Delivery Receipt Modacks
3 participants
@maitrimangal @kamalaboulhosn @hannahrogers-google