Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 #1436

Merged
merged 2 commits into from
Dec 14, 2022
Merged

deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 #1436

merged 2 commits into from
Dec 14, 2022

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Dec 6, 2022 •
edited

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-shared-dependencies 3.0.6 -> 3.1.0 age adoption passing confidence

Release Notes

googleapis/java-shared-dependencies

v3.1.0

Compare Source

Features
Dependencies

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from a team as code owners December 6, 2022 00:04
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@forking-renovate
Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@suztomo
Copy link
Member

suztomo commented Dec 14, 2022

ci / units (11) failed:

Error:  Failures: 
Error:    PublisherImplTest.testOrderingKeyWhenDisabled_throwsException:471->shutdownTestPublisher:1315
Error:    PublisherImplTest.testPublishMixedSizeAndDuration:282->shutdownTestPublisher:1315
Error:    PublisherImplTest.testResumePublish:591->shutdownTestPublisher:1315

https://github.com/googleapis/java-pubsub/actions/runs/3696936954/jobs/6261301989

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud-google-cloud-shared-dependencies-3.x branch from 5972398 to 6a667fc Compare December 14, 2022 17:40
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@suztomo
Copy link
Member

suztomo commented Dec 14, 2022 •
edited

The same set of tests failed again.

Error:  Failures: 
Error:    PublisherImplTest.testOrderingKeyWhenDisabled_throwsException:471->shutdownTestPublisher:1315
Error:    PublisherImplTest.testPublishMixedSizeAndDuration:282->shutdownTestPublisher:1315
Error:    PublisherImplTest.testResumePublish:591->shutdownTestPublisher:1315

Picking one of them:

2022-12-14T17:53:55.8318809Z [ERROR] com.google.cloud.pubsub.v1.PublisherImplTest.testOrderingKeyWhenDisabled_throwsException  Time elapsed: 60.004 s  <<< FAILURE!
2022-12-14T17:53:55.8338191Z java.lang.AssertionError
2022-12-14T17:53:55.8338461Z 	at org.junit.Assert.fail(Assert.java:87)
2022-12-14T17:53:55.8338767Z 	at org.junit.Assert.assertTrue(Assert.java:42)
2022-12-14T17:53:55.8339072Z 	at org.junit.Assert.assertTrue(Assert.java:53)
2022-12-14T17:53:55.8339534Z 	at com.google.cloud.pubsub.v1.PublisherImplTest.shutdownTestPublisher(PublisherImplTest.java:1315)
2022-12-14T17:53:55.8340187Z 	at com.google.cloud.pubsub.v1.PublisherImplTest.testOrderingKeyWhenDisabled_throwsException(PublisherImplTest.java:471)
2022-12-14T17:53:55.8340770Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2022-12-14T17:53:55.8351268Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2022-12-14T17:53:55.8351934Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2022-12-14T17:53:55.8353044Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2022-12-14T17:53:55.8353463Z 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
2022-12-14T17:53:55.8354112Z 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2022-12-14T17:53:55.8354659Z 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2022-12-14T17:53:55.8355175Z 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2022-12-14T17:53:55.8355676Z 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
2022-12-14T17:53:55.8356146Z 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
2022-12-14T17:53:55.8356574Z 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
2022-12-14T17:53:55.8357001Z 	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
2022-12-14T17:53:55.8357412Z 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
2022-12-14T17:53:55.8357854Z 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
2022-12-14T17:53:55.8358344Z 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
2022-12-14T17:53:55.8358768Z 	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
2022-12-14T17:53:55.8359244Z 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
2022-12-14T17:53:55.8359644Z 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
2022-12-14T17:53:55.8376340Z 	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
2022-12-14T17:53:55.8376816Z 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
2022-12-14T17:53:55.8377203Z 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
2022-12-14T17:53:55.8377583Z 	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
2022-12-14T17:53:55.8377934Z 	at org.junit.runners.Suite.runChild(Suite.java:128)
2022-12-14T17:53:55.8378243Z 	at org.junit.runners.Suite.runChild(Suite.java:27)
2022-12-14T17:53:55.8378590Z 	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
2022-12-14T17:53:55.8378970Z 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
2022-12-14T17:53:55.8379506Z 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
2022-12-14T17:53:55.8379934Z 	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
2022-12-14T17:53:55.8380319Z 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
2022-12-14T17:53:55.8380682Z 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
2022-12-14T17:53:55.8381058Z 	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
2022-12-14T17:53:55.8381464Z 	at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
2022-12-14T17:53:55.8382014Z 	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
2022-12-14T17:53:55.8382611Z 	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107)
2022-12-14T17:53:55.8383174Z 	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83)
2022-12-14T17:53:55.8386556Z 	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
2022-12-14T17:53:55.8398383Z 	at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158)
2022-12-14T17:53:55.8399689Z 	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
2022-12-14T17:53:55.8400300Z 	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
2022-12-14T17:53:55.8400839Z 	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
2022-12-14T17:53:55.8401341Z 	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)

Failed assertion:

  private void shutdownTestPublisher(Publisher publisher) throws InterruptedException {
    publisher.shutdown();
    fakeExecutor.advanceTime(Duration.ofSeconds(10));
    assertTrue(publisher.awaitTermination(1, TimeUnit.MINUTES));
  }

publisher.awaitTermination implementation:

  /**
   * Wait for all work has completed execution after a {@link #shutdown()} request, or the timeout
   * occurs, or the current thread is interrupted.
   *
   * <p>Call this method to make sure all resources are freed properly.
   */
  public boolean awaitTermination(long duration, TimeUnit unit) throws InterruptedException {
    return backgroundResources.awaitTermination(duration, unit);
  }

The Javadoc of awaitTermination doesn't explain the return value.

https://github.com/googleapis/gax-java/blob/v2.20.1/gax/src/main/java/com/google/api/gax/core/BackgroundResource.java#L74

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@hannahrogers-google hannahrogers-google merged commit a40337b into googleapis:main Dec 14, 2022
@release-please release-please bot mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@renovate-bot @suztomo @hannahrogers-google @yoshi-kokoro