Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding an explicit check to prevent empty publishes #1376

Merged
merged 2 commits into from
Oct 28, 2022
Merged

fix: adding an explicit check to prevent empty publishes #1376

merged 2 commits into from
Oct 28, 2022

Conversation

mmicatka
Copy link
Contributor

Adding an explicit check to prevent a publish attempt with no messages.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Oct 28, 2022
@mmicatka mmicatka marked this pull request as ready for review October 28, 2022 16:33
@mmicatka mmicatka requested a review from a team as a code owner October 28, 2022 16:33
@mmicatka mmicatka added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 28, 2022
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner October 28, 2022 16:54
@mmicatka mmicatka merged commit 689d7da into googleapis:main Oct 28, 2022
@release-please release-please bot mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmicatka @hannahrogers-google