Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make partialSuccess to be true by default #1173

Merged
merged 3 commits into from
Nov 2, 2022
Merged

fix: Make partialSuccess to be true by default #1173

merged 3 commits into from
Nov 2, 2022

Conversation

losalex
Copy link
Contributor

@losalex losalex commented Nov 1, 2022

Fixes #1172 ☕️

@losalex losalex requested review from a team as code owners November 1, 2022 00:00
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/java-logging API. labels Nov 1, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 2, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Nov 2, 2022
@losalex losalex merged commit 123960a into main Nov 2, 2022
@losalex losalex deleted the losalex/feat-partialsuccess-default branch November 2, 2022 21:54
@release-please release-please bot mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@losalex @daniel-sanche