Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: use error_prone_annotation via shared deps #1049

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Aug 29, 2022

Declaring the error_prone_annotation version fails consistency check in downstream repository:

googleapis/java-logging-logback#829 (comment)

Reading #1009, it shouldn't need the independent version declared here.

@suztomo suztomo requested review from a team as code owners August 29, 2022 16:26
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/java-logging API. labels Aug 29, 2022
@suztomo suztomo requested a review from lqiu96 August 29, 2022 16:27
@lqiu96 lqiu96 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 29, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0998b9b into main Aug 29, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the suztomo-patch-1 branch August 29, 2022 17:14
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 29, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 29, 2022
🤖 I have created a release *beep* *boop*
---


## [3.10.6](v3.10.5...v3.10.6) (2022-08-29)


### Dependencies

* use error_prone_annotation via shared deps ([#1049](#1049)) ([0998b9b](0998b9b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants