Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resource detection for 2nd gen of Cloud Functions works incorrectly #1045

Merged
merged 2 commits into from
Aug 25, 2022
Merged

fix: resource detection for 2nd gen of Cloud Functions works incorrectly #1045

merged 2 commits into from
Aug 25, 2022

Conversation

losalex
Copy link
Contributor

@losalex losalex commented Aug 24, 2022

Fixes #989 ☕️

@losalex losalex requested review from a team as code owners August 24, 2022 22:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/java-logging API. labels Aug 24, 2022
@daniel-sanche
Copy link
Contributor

Are there any tests that could be added for this?

minherz
minherz approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you for taking care of it.

@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 25, 2022
@losalex
Copy link
Contributor Author

losalex commented Aug 25, 2022

Are there any tests that could be added for this?

Yep - modified existing one to fit new logic

@losalex losalex merged commit dda1d0a into main Aug 25, 2022
@losalex losalex deleted the losalex/fix-989 branch August 25, 2022 16:59
@release-please release-please bot mentioned this pull request Aug 25, 2022
Merged
@dan-wu-open dan-wu-open mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@minherz minherz minherz approved these changes

Assignees
No one assigned
Labels
api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@losalex @daniel-sanche @minherz @yoshi-kokoro