Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply Google Java Code Clarity suggestions #1044

Merged
merged 2 commits into from
Sep 7, 2022
Merged

fix: Apply Google Java Code Clarity suggestions #1044

merged 2 commits into from
Sep 7, 2022

Conversation

bpcreech
Copy link
Contributor

Fixes #1043

@bpcreech bpcreech requested review from a team as code owners August 24, 2022 02:02
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 24, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/ConfigClient.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/ConfigSettings.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/LoggingClient.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/LoggingSettings.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/MetricsClient.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/MetricsSettings.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/ConfigServiceV2StubSettings.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/GrpcConfigServiceV2Stub.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/GrpcLoggingServiceV2Stub.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/GrpcMetricsServiceV2Stub.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/LoggingServiceV2StubSettings.java
  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/MetricsServiceV2StubSettings.java
  • google-cloud-logging/src/test/java/com/google/cloud/logging/v2/MockConfigServiceV2Impl.java
  • google-cloud-logging/src/test/java/com/google/cloud/logging/v2/MockLoggingServiceV2Impl.java
  • google-cloud-logging/src/test/java/com/google/cloud/logging/v2/MockMetricsServiceV2Impl.java

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Aug 24, 2022
losalex
losalex reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment regarding changed exception thrown by code.

google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java Show resolved Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java Show resolved Hide resolved
@losalex losalex self-assigned this Aug 26, 2022
@bpcreech
Copy link
Contributor Author

Oh this was angering clirr because (per internal linter), I made a couple trivial breaking changes to the Instrumentation class. This class was holding only static things, so I marked it as final and made the ctor private to make it clear it shouldn't be instantiated. This is technically a breaking change! I could undo it if you want! Instead I marked it as an ignored difference for clirr because there should be no motivation for anyone to have ever instantiated that class to begin with.

@losalex
Copy link
Contributor

losalex commented Aug 29, 2022

Oh this was angering clirr because (per internal linter), I made a couple trivial breaking changes to the Instrumentation class. This class was holding only static things, so I marked it as final and made the ctor private to make it clear it shouldn't be instantiated. This is technically a breaking change! I could undo it if you want! Instead I marked it as an ignored difference for clirr because there should be no motivation for anyone to have ever instantiated that class to begin with.

Instrumentation is intended for internal usage only and making this final is OK if it doesn't breaks anything.

@losalex losalex added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2022
@losalex losalex merged commit 79e9d8d into googleapis:main Sep 7, 2022
@release-please release-please bot mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/java-logging API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's apply our internal automated linter fixes
3 participants
@bpcreech @losalex @yoshi-kokoro