fix: Make LoggingHandler.logEntryFor extensible #1021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stopgap solution suggested by minherz@ in #747. The long-term fix is #32 but that seems like it could take some time (it's been open 3 years and is pending a major version bump).
This enables us to enhance the
c.g.cloud.logging.LogEntry
in ways that require access to the originaljava.util.logging.LogRecord
, e.g.:SourceLocation
using extra, more accurate context the Google Flogger library captures (on a subclass of the JULLogRecord
),logRecord.getThreadID
,record.getThrown()
,