Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the stub to avoid the deprecated *Map method #1002

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

bpcreech
Copy link
Contributor

@bpcreech bpcreech commented Jul 23, 2022

Fixes #1001

This could potentially also be fixed by regenerating the stub. Figured we might put this in ahead of that... it can be safely overwritten the next time someone runs the generator.

@bpcreech bpcreech requested review from a team as code owners July 23, 2022 20:02
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 23, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • google-cloud-logging/src/main/java/com/google/cloud/logging/v2/stub/LoggingServiceV2StubSettings.java

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jul 23, 2022
@losalex losalex self-assigned this Jul 31, 2022
@losalex losalex changed the title Update the stub to avoid the deprecated *Map method fix: Update the stub to avoid the deprecated *Map method Aug 10, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2022
@losalex losalex added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@losalex losalex merged commit 49bf5b4 into googleapis:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogEntry.java references deprecated method entryPb.getLabels()
3 participants