fix: Set a default mtls endpoint value #2577
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
|
Hi @mutianf and @andre-sampaio, this is the proposed change that I was thinking about doing inside the BigTable repo. However, I just had some hesitations regarding existing mTLS behavior in BigTable. BigTable's EnhancedStubSettings wrappers don't directly extend from the generated StubSettings class (only directly from Gax's StubSettings): It looks to be missing the mtlsEndpoint that we set for all GAPICs in the generated StubSettings class: Let us know what you think about this and/ or if this has an unintended side effects. Thanks! FYI, I pulled in the existing shared-deps PR to show that this fix would also work even without the upstream Gax fix. |
mutianf
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a default mTLSEndpoint value to pass to Gax.
For this draft PR, I also pulled in the shared-deps PR changes that introduced these DirectPath issues.