Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change types for Cloud Bigtable Changestream methods #1639

Merged
merged 3 commits into from
Feb 17, 2023
Merged

fix: Change types for Cloud Bigtable Changestream methods #1639

merged 3 commits into from
Feb 17, 2023

Conversation

tengzhonger
Copy link
Contributor

@tengzhonger tengzhonger commented Feb 17, 2023 •
edited

Use org.threeten.bp.Instant for below fields:

  • startTime
  • endTime
  • commitTimestamp
  • estimatedLowWatermark

Use bigtable.common.Status for CloseStream::getStatus()

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

fix: Use org.threeten.bp.Instant for some Changestream methods
7b92396 
startTime
endTime
commitTimestamp
estimatedLowWatermark
@tengzhonger tengzhonger requested review from a team as code owners February 17, 2023 14:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Feb 17, 2023
@tengzhonger tengzhonger changed the title fix: Use org.threeten.bp.Instant for some Changestream methods fix: Change types for Cloud Bigtable Changestream methods Feb 17, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 17, 2023
@igorbernstein2 igorbernstein2 added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 17, 2023
@mutianf mutianf added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 17, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 908d70f into googleapis:main Feb 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 17, 2023
@release-please release-please bot mentioned this pull request Feb 17, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 21, 2023
@release-please
chore(main): release 2.19.2 (#1641)
6abddc6 
🤖 I have created a release *beep* *boop*
---


## [2.19.2](https://togithub.com/googleapis/java-bigtable/compare/v2.19.1...v2.19.2) (2023-02-21)


### Bug Fixes

* Change types for Cloud Bigtable Changestream methods ([#1639](https://togithub.com/googleapis/java-bigtable/issues/1639)) ([908d70f](https://togithub.com/googleapis/java-bigtable/commit/908d70fdfa22e563031e2d8780b574ee7350cadc))


### Dependencies

* Update shared deps to 3.3.0 and monitoring to 3.12.0 ([#1643](https://togithub.com/googleapis/java-bigtable/issues/1643)) ([1a54fbf](https://togithub.com/googleapis/java-bigtable/commit/1a54fbf22490e5a83df0b0d73dc4b30472175102))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@tengzhonger tengzhonger deleted the cdc_fix2 branch February 26, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tengzhonger @igorbernstein2 @mutianf @yoshi-kokoro