Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable channel priming by default #1555

Merged
merged 8 commits into from
Dec 16, 2022
Merged

feat: enable channel priming by default #1555

merged 8 commits into from
Dec 16, 2022

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Dec 14, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf marked this pull request as ready for review December 14, 2022 16:23
@mutianf mutianf requested a review from a team as a code owner December 14, 2022 16:23
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 14, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 15, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Dec 15, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 15, 2022
igorbernstein2
igorbernstein2 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 15, 2022
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2022
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 16, 2022
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2022
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner December 16, 2022 16:16
@gcf-merge-on-green gcf-merge-on-green bot merged commit 303959c into googleapis:main Dec 16, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2022
@mutianf mutianf deleted the prime branch December 16, 2022 16:38
@release-please release-please bot mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mutianf @igorbernstein2 @yoshi-kokoro