feat: copy backup API support #1398

TracyCuiCan · 2022-09-15T20:38:43Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

generated-files-bot · 2022-09-15T20:38:49Z

Warning: This pull request is touching the following templated files:

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminSettings.java
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStub.java
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStubSettings.java
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminStub.java
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClientTest.java
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdminImpl.java
grpc-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/BigtableTableAdminGrpc.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/Backup.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/BackupInfo.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/BackupInfoOrBuilder.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/BackupOrBuilder.java
proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/BigtableTableAdminProto.java
proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto
proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/table.proto

kolea2 · 2022-09-16T16:59:47Z

google-cloud-bigtable-stats/dependency-reduced-pom.xml

@@ -0,0 +1,408 @@
+<?xml version="1.0" encoding="UTF-8"?>


I think this should be reverted?

I see that the same change was committed 12 days ago to https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable-stats/pom.xml. This was a valid change back then and should be no change now.

this is the dependency-reduced-pom.xml which gets generated (as opposed to pom.xml) and it should be reverted.

(separately we should figure out how to exclude this - maybe in .gitignore

I see, I'll remove this file from the PR. Will figure out how to exclude this and make changes in a different PR, sounds good?

perfect, thanks!

...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CopyBackupRequest.java

...bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTests.java

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableBackupIT.java

...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java

...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CopyBackupRequest.java

This reverts commit b6efd2d.

This reverts commit f446cd0.

kolea2 · 2022-10-18T14:19:07Z

google-cloud-bigtable-stats/dependency-reduced-pom.xml

@@ -0,0 +1,408 @@
+<?xml version="1.0" encoding="UTF-8"?>


this is the dependency-reduced-pom.xml which gets generated (as opposed to pom.xml) and it should be reverted.

kolea2 · 2022-10-18T14:22:05Z

...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CopyBackupRequest.java

+ * #of(String, String, String, String) of} method
+ */
+ public static CopyBackupRequest of(String clusterId, String backupId) {
+ CopyBackupRequest request = new CopyBackupRequest(null, null, clusterId, backupId);


This doesn't seem to match up - clusterId is the 3rd parameter, but the 3rd parameter should be instanceId per the method signature: https://github.com/googleapis/java-bigtable/pull/1398/files#diff-f22bea44852cc477c88df0651b15890d220ccbfdf7f998d0e97bc6c30d409b8bR65

The private method is defined as:
private CopyBackupRequest(
@nullable String sourceProjectId,
@nullable String sourceInstanceId,
@nonnull String sourceClusterId,
@nonnull String sourceBackupId);
The 3rd parameter is ClusterId, the order of parameters of the private method and the public ones are different, should I match them?

got it - in this case, the private method should follow the order of the public ones to avoid confusion (like I just had :)). It will also change the order so the null parameters will go toward the end, which is more typical and expected.

sg, I'll udpate!

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableBackupIT.java

…y-reduced-pom.xml

kolea2

lgtm with just some last suggestions on method and variable naming. Thanks for putting this together!

...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CopyBackupRequest.java

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableBackupIT.java

waiting on update/ review from Igor

...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CopyBackupRequest.java

Change CopyBackup method to make it more readable

...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CopyBackupRequest.java

🤖 I have created a release *beep* *boop* --- ## [2.27.0](https://togithub.com/googleapis/java-bigtable/compare/v2.26.0...v2.27.0) (2023-08-17) ### Features * Copy backup API support ([#1398](https://togithub.com/googleapis/java-bigtable/issues/1398)) ([558a408](https://togithub.com/googleapis/java-bigtable/commit/558a408f5fa0566652df923799cf9f7bc03f7194)) * Publish CopyBackup protos to external customers ([#1883](https://togithub.com/googleapis/java-bigtable/issues/1883)) ([d6e934f](https://togithub.com/googleapis/java-bigtable/commit/d6e934fc71e1c1dd4e13492d2f6c4688b6b0d59d)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Tracy Cui and others added 2 commits September 15, 2022 16:33

feat: copy backup API support

447a376

Merge branch 'googleapis:main' into main

64c728e

TracyCuiCan requested review from a team as code owners September 15, 2022 20:38

product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 15, 2022

TracyCuiCan and others added 2 commits September 16, 2022 10:59

Merge branch 'googleapis:main' into main

6861857

revert auto gen changes/files for copy backup API

b6efd2d

kolea2 requested changes Sep 16, 2022

View reviewed changes

TracyCuiCan and others added 5 commits October 10, 2022 11:20

Merge branch 'googleapis:main' into main

5293783

Merge branch 'googleapis:main' into main

c4f5912

Revert "revert auto gen changes/files for copy backup API"

f446cd0

This reverts commit b6efd2d.

address comments

fbab9cf

Revert "Revert "revert auto gen changes/files for copy backup API""

56a7a67

This reverts commit f446cd0.

kolea2 requested changes Oct 18, 2022

View reviewed changes

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableBackupIT.java Show resolved Hide resolved

TracyCuiCan and others added 2 commits October 19, 2022 14:33

Merge branch 'googleapis:main' into main

78d2fd5

change params order in private CopyBackupRequest and remove dependenc…

12618af

…y-reduced-pom.xml

product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Oct 20, 2022

kolea2 previously approved these changes Oct 24, 2022

View reviewed changes

kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2022

TracyCuiCan and others added 2 commits October 26, 2022 11:43

Merge branch 'googleapis:main' into main

92d6018

Rename variables in CopyBackupRequest to reduce confusion.

b5f213c

kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2022

TracyCuiCan added 2 commits December 1, 2022 15:12

Merge branch 'googleapis:main' into main

1338c93

Merge branch 'googleapis:main' into main

2c48f2b

Merge branch 'googleapis:main' into main

b6db4ad

igorbernstein2 reviewed Aug 16, 2023

View reviewed changes

Tracy Cui and others added 4 commits August 16, 2023 18:49

update request code

2b5f9d6

udpate test

435c026

Merge pull request #1 from TracyCuiCan/copy-backup

d17ce3b

Change CopyBackup method to make it more readable

update CopyBackup method

3058bee

igorbernstein2 approved these changes Aug 17, 2023

View reviewed changes

...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/CopyBackupRequest.java Outdated Show resolved Hide resolved

Tracy Cui added 2 commits August 17, 2023 13:59

remove dead code

952e796

format new files

b0da4d8

igorbernstein2 added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 17, 2023

mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2023

mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2023

mutianf merged commit 558a408 into googleapis:main Aug 17, 2023
20 of 21 checks passed

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 17, 2023

release-please bot mentioned this pull request Aug 16, 2023

chore(main): release 2.27.0 #1887

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: copy backup API support #1398

feat: copy backup API support #1398

TracyCuiCan commented Sep 15, 2022

generated-files-bot bot commented Sep 15, 2022

kolea2 Sep 16, 2022

TracyCuiCan Oct 17, 2022

kolea2 Oct 18, 2022

kolea2 Oct 18, 2022

TracyCuiCan Oct 20, 2022

kolea2 Oct 24, 2022

kolea2 Oct 18, 2022

kolea2 Oct 18, 2022

TracyCuiCan Oct 19, 2022

kolea2 Oct 19, 2022

TracyCuiCan Oct 20, 2022

kolea2 left a comment

feat: copy backup API support #1398

feat: copy backup API support #1398

Conversation

TracyCuiCan commented Sep 15, 2022

generated-files-bot bot commented Sep 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kolea2 left a comment

Choose a reason for hiding this comment