feat: add reference file schema option for federated formats #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shollyman
reviewed
Sep 12, 2022
| @@ -317,6 +328,15 @@ com.google.api.services.bigquery.model.ExternalDataConfiguration toExternalDataC | |||
| if (getAutodetect() != null) { | |||
| externalConfigurationPb.setAutodetect(getAutodetect()); | |||
| } | |||
| if (FormatOptions.AVRO.equals(getFormatOptions().getType()) | |||
There was a problem hiding this comment.
There's a philosophical question here around enforcing logic in the client versus just propagating what the user sets. Generally we've favored allowed the backend to evaluate these kinds of things.
| Job job = bigquery.create(JobInfo.of(loadJobConfiguration)); | ||
| // Blocks until this load table job completes its execution, either failing or succeeding. | ||
| job = job.waitFor(); | ||
| if (job.isDone()) { |
There was a problem hiding this comment.
this logic seems odd (here and in the other variants). A job can be done with or without an error attached. you can just assert the job completed without errors?
Also, as this doesn't appear to be a sample it's not clear what emitting to system.out is getting you.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
🤖 I have created a release *beep* *boop* --- ## [2.16.0](v2.15.0...v2.16.0) (2022-09-12) ### Features * Add preserveAsciiControlCharacters to CsvOptions ([#2143](#2143)) ([856893f](856893f)) * Add reference file schema option for federated formats ([#2269](#2269)) ([8c488e6](8c488e6)) ### Bug Fixes * Socket-timeout at bigquery.it.ITNightlyBigQueryTest: testForTableNotFound ([#2260](#2260)) ([a9b5fb2](a9b5fb2)) ### Dependencies * Update dependency com.google.apis:google-api-services-bigquery to v2-rev20220827-2.0.0 ([#2261](#2261)) ([3c67d21](3c67d21)) * Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.9.3 ([#2259](#2259)) ([5e30a04](5e30a04)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#2267](#2267)) ([8472fe5](8472fe5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.