Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): Adding tracing to run method #9602

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Mar 18, 2024

Find info in #9464

@bhshkh bhshkh requested review from a team as code owners March 18, 2024 16:39
@product-auto-label product-auto-label bot added the api: datastore Issues related to the Datastore API. label Mar 18, 2024
@bhshkh bhshkh requested a review from gkevinzheng March 18, 2024 16:39
@bhshkh bhshkh linked an issue Mar 18, 2024 that may be closed by this pull request
@bhshkh bhshkh removed the request for review from gkevinzheng March 18, 2024 16:40
@notcool11
Copy link

thank you!

do you know if i will get notified for if/when this PR makes it into a release so i can pull that version of the package? thanks again!

@bhshkh
Copy link
Contributor Author

bhshkh commented Mar 27, 2024

thank you!

do you know if i will get notified for if/when this PR makes it into a release so i can pull that version of the package? thanks again!

Once the PR is merged, it will be included in the next release which is 1.16.0

You can subscribe to #8711 to get notified.

@bhshkh
Copy link
Contributor Author

bhshkh commented Mar 29, 2024

Do not merge until release freeze ends in mid April

@bhshkh bhshkh added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 29, 2024
@bhshkh bhshkh removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 16, 2024
@bhshkh bhshkh enabled auto-merge (squash) April 16, 2024 00:18
@bhshkh bhshkh merged commit a5e197c into googleapis:main Apr 16, 2024
8 checks passed
@bhshkh bhshkh deleted the fix/issue-9464 branch April 16, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datastore: missing tracing from run method in query.go
3 participants