Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): update allowed message retention duration by server #8559

Merged

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Sep 12, 2023

Fixes #8558

This PR also cleans up the topic retention test to use the new max value and removes the unnecessary retry wrapper now that resource creation goes through a helper function that is retried. No test logic was changed.

@hongalex hongalex requested review from shollyman and a team as code owners September 12, 2023 21:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the Pub/Sub API. labels Sep 12, 2023
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Oct 13, 2023
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Nov 12, 2023
@hongalex hongalex merged commit 78c178b into googleapis:main Jan 19, 2024
9 checks passed
@hongalex hongalex deleted the doc-pubsub-update-retention-duration branch January 19, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. size: m Pull request size is medium. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub: update message retention duration documentation
2 participants