feat(bigquery): expose dataset MaxTimeTravelHours #7706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
reviewed
Apr 7, 2023
| @@ -58,6 +58,10 @@ type DatasetMetadata struct { | |||
| // More information: https://cloud.google.com/bigquery/docs/reference/standard-sql/collation-concepts | |||
| DefaultCollation string | |||
|
|
|||
| // MaxTimeTravelHours represents the number of hours for the max time travel for all tables | |||
| // in the dataset. Durations are rounded towards zero for the nearest hourly value. | |||
| MaxTimeTravelHours time.Duration | |||
There was a problem hiding this comment.
nit: I get the intention with the word Hours here, but it does feel a little off since this is just a duration. Maybe drop hours. Also maybe TraversalTime instead of TimeTravel -- although it does sound cool 🚀
codyoss
approved these changes
Apr 7, 2023
shollyman
added a commit
to shollyman/google-cloud-go
that referenced
this pull request
Apr 7, 2023
PR googleapis#7706 submitted before the edit to shorten the name landed. This PR updates it.
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.