fix(bigquery/storage/managedwriter): fix option propagation #7669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent refactors, call options were not being propagated properly for non-multiplex writers.
We initially created a pool-per-writer and thus resolved these differences via the settings on the pool,
but have improved this situation to have a pool-per-region. The custom settings were being silently
dropped on the floor. The impacted settings were the connection-related options, namely flow control limits and custom call options.
With this change we allow for default settings on the pool, and custom settings on a connection. In usage, this
is only leveraged for non-multiplexed connections as we have 1:1 relationships between connections and writers.
Towards: #7103