fix(pubsub): check response of receipt modacks for exactly once delivery #7568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oogle-cloud-go; branch 'main' of github.com:googleapis/google-cloud-go into fix-pubsub-receipt-modack-eod
shollyman
reviewed
Mar 16, 2023
pubsub/iterator.go
Outdated
| if err != nil { | ||
| delete(pendingMessages, ackID) | ||
| it.mu.Lock() | ||
| defer it.mu.Unlock() |
There was a problem hiding this comment.
This defer seems problematic for unlocking. What happens when a second entry in this for loop has an error?
There was a problem hiding this comment.
good catch, removed the use of defer here
maheshgattani
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the behavior of receipt modacks with the Python client. Specifically, if exactly once delivery is enabled, receipt modacks that fail should be retried up to 3 times (similar to lease modacks), but message processing should be blocked on the result of this modack.
This PR also removes a test with the fake since
DeadlineExceedederrors will never happen in theNackcase if modacks are never successful.Fixes #7585