Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery/storage/managedwriter): fix incorrect error retention #6659

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

shollyman
Copy link
Contributor

Failures for an individual append can get retained as the terminal error for the stream. Redact the logic responsible, and add a test that validates the correct behavior using context-based errors.

Fixes: #6657

Failures for an individual append can get retained as the terminal
error for the stream.  Redact the logic responsible, and add a test
that validates the correct behavior using context-based errors.
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the BigQuery API. labels Sep 13, 2022
@shollyman shollyman marked this pull request as ready for review September 13, 2022 18:08
@shollyman shollyman requested a review from a team September 13, 2022 18:08
@shollyman shollyman requested a review from a team as a code owner September 13, 2022 18:08
@shollyman shollyman requested review from aribray and alvarowolfx and removed request for aribray September 13, 2022 18:08
Copy link
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit dc02bca into googleapis:main Sep 13, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery/storage: ManagedStream should not hold context.Canceled and context.DeadlineExceeded error
2 participants