feat(bigquery/storage/managedwriter): refactor AppendResponse #6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The potential fields exposed within an AppendResponse has grown as the API has evolved. This PR refactors AppendResult to use a retained reference of the response for servicing requests. This allows the logic for processing the response to be centralized a bit more within the AppendResult. We also introduce a new RawResponse() on the AppendResult which returns the full AppendRowsResponse if present.
yirutang
reviewed
Jul 28, 2022
Existing users can continue to use |
|
What are the other things you want to expose through FullResponse()? (I
like that name better)
…On Thu, Jul 28, 2022 at 3:15 PM shollyman ***@***.***> wrote:
I am not sure, is this changing the public interface?
Existing users can continue to use GetResult() on the returned future
which returns the same (offset, error) tuple without change. The difference
is that the future now exposes the GetRawResult() as an alternative,
which returns the full AppendRowsResponse. I'm still not enamored of the
method name, perhaps FullResponse() is a better choice?
—
Reply to this email directly, view it on GitHub
<#6402 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGYVETY3MBHZ4SJU3KNCALVWMA6XANCNFSM54MTYV7Q>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Thanks.
Yiru
|
The error row information, and any new fields we have from future features (multiplexing, cdc, etc). I can also leave the full response off for now, and proceed with the rest of the refactor. |
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The potential fields exposed within an AppendResponse has grown as
the API has evolved. This PR refactors AppendResult to use a
retained reference of the response for servicing requests.
This allows the logic for processing the response to be centralized
a bit more within the AppendResult. We also introduce a new
FullResponse() on the AppendResult which returns the full
AppendRowsResponse if present.