Skip to content

feat(storage): Restart & delete resumable upload part 2 #23376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(storage): Restart & delete resumable upload part 2 #23376

wants to merge 4 commits into from

Conversation

shubhangi-google
Copy link
Contributor

Feature to support Restart and Delete resumable upload functionality

@example   

storage = Google::Cloud::Storage.new
bucket = storage.bucket bucket_name
## sample upload_id=  "AKDAyIs3wDvKFtl2e4PopZi-YtGZDxFr2vlR4Z58T6hL9Seypi5W2s7vrRe6-Qw5Fur79g11bT7MtcsSu-vYRkm5nVUKPpm_ciLPn65GQDqNMQ"
#Initiating Resumable upload 
bucket.create_file file, file_name
#Restarting  Resumable upload 
bucket.restart_resumable_upload file, upload_id
#Deleting Resumable upload 
bucket.delete_resumable_upload upload_id

storage library Implementation linked with- googleapis/google-cloud-ruby#29215
Core library Implementation(merged): #21896

@shubhangi-google shubhangi-google requested a review from a team as a code owner June 13, 2025 10:12
@shubhangi-google shubhangi-google mentioned this pull request Jun 13, 2025
Open
bajajneha27
bajajneha27 reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have to update the tests accordingly?

@shubhangi-google
Copy link
Contributor Author

Shouldn't we have to update the tests accordingly?

updating the test case is not required since we are setting the value of command.delete_upload here
https://github.com/googleapis/google-api-ruby-client/pull/21896/files#diff-064196c57cc405543bd5ca673ab208b2faf5b7526017522e502e87119961b6b0R379

@bajajneha27
Copy link
Contributor

Shouldn't we have to update the tests accordingly?

updating the test case is not required since we are setting the value of command.delete_upload here https://github.com/googleapis/google-api-ruby-client/pull/21896/files#diff-064196c57cc405543bd5ca673ab208b2faf5b7526017522e502e87119961b6b0R379

I can see one place for sure https://github.com/googleapis/google-api-ruby-client/pull/21896/files#diff-760f5664ec67b31a778b73e99c7976822f091ef3ad45eb654a3704c72fb7f555R299

@shubhangi-google
Copy link
Contributor Author

Shouldn't we have to update the tests accordingly?

updating the test case is not required since we are setting the value of command.delete_upload here https://github.com/googleapis/google-api-ruby-client/pull/21896/files#diff-064196c57cc405543bd5ca673ab208b2faf5b7526017522e502e87119961b6b0R379

I can see one place for sure https://github.com/googleapis/google-api-ruby-client/pull/21896/files#diff-760f5664ec67b31a778b73e99c7976822f091ef3ad45eb654a3704c72fb7f555R299

missed it as this was not affecting the test outcome updated it now

@bajajneha27 bajajneha27 requested a review from dazuma June 27, 2025 11:12
@bajajneha27
Copy link
Contributor

@dazuma I'm not sure about the new check multi-approver. I'm not able to merge the PR with just my approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajajneha27 bajajneha27 bajajneha27 approved these changes

@dazuma dazuma Awaiting requested review from dazuma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhangi-google @bajajneha27