Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR 17-18 compliance #1776

Open
ChargemapHakan opened this issue Jan 25, 2020 · 2 comments
Open

PSR 17-18 compliance #1776

ChargemapHakan opened this issue Jan 25, 2020 · 2 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ChargemapHakan
Copy link

ChargemapHakan commented Jan 25, 2020 •
edited

Is your feature request related to a problem? Please describe.
It may cause transitivity issues when the project using / requiring this library also needs another version of Guzzle Http Client.

Describe the solution you'd like
It would be awesome to use PSR 17 HttpClientInterface instead of the concrete Guzzle Client class. Also, using RequestInterfaces, StreamInterfaces and their respective factories for payload would make sense IMHO.

Injecting the Client and Request factories (DIP) would be awesome but using discovery mechanism can also be something we can imagine.

More context
For instance, this library : https://packagist.org/packages/aporat/store-receipt-validator depends on Guzzle as well and we may have transitivity issues.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jan 26, 2020
@jdpedrie jdpedrie added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jan 28, 2020
@jdpedrie
Copy link
Contributor

Thank you for the suggestion. We will consider it along with other planned changes!

@tacman
Copy link

tacman commented May 20, 2024

Hi, I see you just dropped support for Guzzle 6 and PHP 7.4 -- great! Perhaps that opens up an opportunity for using other http clients.

I'm a fan of the Symfony http client, because the requests are automatically logged in the debugger. Plus, it's already installed in my project, I'd prefer not to also download Guzzle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdpedrie @tacman @yoshi-automation @ChargemapHakan