Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullReferenceException trying to clear tracker parameter (iOS) #161

Open
nicolasjinchereau opened this issue Oct 4, 2017 · 0 comments
Open

NullReferenceException trying to clear tracker parameter (iOS) #161

nicolasjinchereau opened this issue Oct 4, 2017 · 0 comments

Comments

@nicolasjinchereau
Copy link
Contributor

To clear a parameter, you should pass nil to value:

google-analytics-plugin-for-unity/source/Plugins/iOS-nobitcode/GAITracker.h

Lines 33 to 37 in 49a1ddf

@param value The value to set for the parameter. If this is nil, the
value for the parameter will be cleared.
*/
- (void)set:(NSString *)parameterName
value:(NSString *)value;

But first, this call is made, which calls +(NSString)stringWithUTF8String on value, which will throw when null is passed.

google-analytics-plugin-for-unity/source/Plugins/iOS-bitcode/GAIHandler.m

Lines 108 to 113 in 49a1ddf

void set(const char * parameterName, const char * value ) {
id<GAITracker> tracker = [[GAI sharedInstance] defaultTracker];
[tracker set:[NSString stringWithUTF8String:parameterName]
value:[NSString stringWithUTF8String:value ]];
}

But before calling those two, you must call this in C#, which calls ToString() on the value without checking if it's null.

google-analytics-plugin-for-unity/source/Plugins/GoogleAnalyticsV3/GAIHandler.cs

Lines 95 to 97 in 5a5caee

public void _set(string parameterName, object value){
set(parameterName, value.ToString());
}

Finally, SetTrackerVal, which should be able to accept null to clear parameters, but crashes due to aforementioned problems.

google-analytics-plugin-for-unity/source/Plugins/GoogleAnalyticsV3/GoogleAnalyticsiOSV3.cs

Lines 124 to 126 in 5a5caee

public void SetTrackerVal(Field fieldName, object value){
handler._set(fieldName.ToString(), value);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolasjinchereau