Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapi.auth.authorized with response_type='id_token' broken #123

Open
wonderfly opened this issue Jan 7, 2015 · 3 comments
Open

gapi.auth.authorized with response_type='id_token' broken #123

wonderfly opened this issue Jan 7, 2015 · 3 comments
Labels
2–5 stars bug imported Priority-Medium

Comments

@wonderfly
Copy link
Contributor

From [email protected] on January 11, 2014 04:03:51

What steps will reproduce the problem? If possible, provide a live demo of the issue. 1. open http://jsbin.com/uweBAyo/1 2. click on authorize
3. The following error message is shown in the popup: Parameter not allowed for this message type: include_granted_scopes

This only happens for calls to gapi.auth.authorize with response_type set to 'id_token', which worked fine until recently. What is the expected output? What do you see instead? Authorization should succeed. What version of the product are you using? On what operating system? Irrelevant Please provide any additional information below. It works as expected when include_granted_scopes is removed the request parameters (for example by executing delete Sv.params.include_granted_scopes before Sv.callback = ... in the uglified client js client)

Original issue: http://code.google.com/p/google-api-javascript-client/issues/detail?id=123
@wonderfly
Copy link
Contributor Author

From [email protected] on January 29, 2014 09:55:46

Perhaps related, but a previously working app was failing to work after the initial authorization step. (Failure occurred on the second page load). I hacked this in:

gapi.auth.authorize({client_id: clientId, scope: scopes, immediate: true,
include_granted_scopes:false}, handleAuthResult);

and it started working again, sigh.

@wonderfly
Copy link
Contributor Author

From [email protected] on January 29, 2014 11:51:01

@#1: yes, unfortunately include_granted_scopes:false does not work with response_type set to id_token. It's just ignored.

@bahayman
Copy link

bahayman commented Mar 3, 2015

Just ran into this issue. Setting response_type: 'token id_token' fixed it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2–5 stars bug imported Priority-Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bahayman @wonderfly