Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtitles stopped working in 2.16.0 #9658

Closed
bhjortsberg opened this issue Nov 7, 2021 · 2 comments
Closed

Subtitles stopped working in 2.16.0 #9658

bhjortsberg opened this issue Nov 7, 2021 · 2 comments
Assignees
@tonihei
Labels
duplicate

Comments

@bhjortsberg
Copy link

I'm using StylePlayerView for selecting subtitles in the player.
On 2.15.1 everything worked fine. On 2.16.0 selecting subtitles seems broken. Selecting the first subtitle in the list seem to work a few times (ie. going subtitle1 -> none -> subtitle1 -> none -> subtitle1 will also not work after a few switches). Selecting any subtitle but the first has no effect.

Examples where it does not work:
https://devstreaming-cdn.apple.com/videos/streaming/examples/bipbop_16x9/bipbop_16x9_variant.m3u8
https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd
https://media.axprod.net/TestVectors/v7-Clear/Manifest_MultiPeriod_1080p.mpd

I've been running this on Android 11 - OnePlus Nord and Android 12 - Pixel3a Android Emulator.
@moneytoo
Copy link
Contributor

moneytoo commented Nov 7, 2021

It's a bug in 2.16.0: #9649

@tonihei tonihei self-assigned this Nov 8, 2021
@tonihei tonihei closed this as completed Nov 8, 2021
@bhjortsberg
Copy link
Author

Ah, missed that. Thanks for the fix!

@google google locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tonihei tonihei

Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moneytoo @bhjortsberg @tonihei