Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AVI #2092

Closed
bene25 opened this issue Nov 22, 2016 · 39 comments
Closed

Support AVI #2092

bene25 opened this issue Nov 22, 2016 · 39 comments
Assignees

Comments

@bene25
Copy link

bene25 commented Nov 22, 2016

Is it possible to play .avi format on ExoPlayer 2.0.
Due to FrameworkSampleSource are removed, are there any other way to play it?

@ojw28 ojw28 added the question label Nov 24, 2016
@ojw28
Copy link
Contributor

ojw28 commented Nov 24, 2016

No, this is not supported in V2. Someone would have to implement an ExoPlayer AVI extractor. It's unclear there's really any significant demand for it, however.

@ojw28 ojw28 changed the title Play .avi format Exo Player 2.0 Support avi format ExoPlayer V2 Nov 25, 2016
@ojw28 ojw28 removed the question label Nov 25, 2016
@lodup29
Copy link

lodup29 commented Jun 29, 2017

I would also like to see an ExoPlayer avi extractor implemented.

@nero12
Copy link

nero12 commented Dec 22, 2017

Same here, i would love to see .avi extractor, nothing out there ?

@dirondir
Copy link

dirondir commented Jan 6, 2018

I would be happy to see .avi extractor

@Aditya94A
Copy link
Contributor

Any updates on this? This should be bumped up.

The fact that AVI format is horribly outdated and nobody should use it is not going to deter our simple minded users! ~7% of the files that my users try to play every day are AVI. With 20k DAU, this is insane. I get at least one 1-star review everyday specifically about this.

@danyangwu
Copy link

I would also like to see an ExoPlayer avi extractor implemented.

@Pecana
Copy link

Pecana commented Jan 7, 2019

Yes , please add support for this kind of format :-)

@mytvpro
Copy link

mytvpro commented Mar 16, 2019

i believe there is in fact significant demand for this

No, this is not supported in V2. Someone would have to implement an ExoPlayer AVI extractor. It's unclear there's really any significant demand for it, however.

@PriyankaThakkar612
Copy link

Please add support for .avi extractor. We would love to see that.

@AshishPsaini

This comment has been minimized.

@mdtuyen

This comment has been minimized.

@AshishPsaini

This comment has been minimized.

@mdtuyen

This comment has been minimized.

@AshishPsaini

This comment has been minimized.

@HaiderSaleem
Copy link

Still neither avi nor wmv support is added.

@ojw28 ojw28 changed the title Support avi format ExoPlayer V2 Support AVI Sep 2, 2019
@otopba
Copy link

otopba commented Mar 4, 2020

Also waiting for avi support

@Raykud
Copy link

Raykud commented Jul 17, 2020

if they didn't care to add it in the last 4 years, and even marked it as "low priority" (2 years ago) there is ZERO chances they will implement an avi extractor. I say this as I know how google works 🙃 .

@dburckh
Copy link

dburckh commented Aug 21, 2020

No, this is not supported in V2. Someone would have to implement an ExoPlayer AVI extractor. It's unclear there's really any significant demand for it, however.

Although it is not commonly used for streaming, it is still very common in trail cams, lower end dash cams and drones. I don't know how many people I've told to install VLC over the years.

@LukasThijs
Copy link

We still need .avi support why is this being ignored

@mytvpro
Copy link

mytvpro commented Oct 29, 2020

We still need .avi support why is this being ignored

Because they think no one needs it even though we all keep saying we do

@ojw28
Copy link
Contributor

ojw28 commented Oct 29, 2020

To clarify, we do understand there's some demand and value to implementing this. As is the case with most widely used open source projects, we receive far more requests than we're able to handle, and we need to prioritize what we work on fairly ruthlessly. This feature is not important enough for us to work on at this point in time.

We accept open source contributions, and would accept a high quality pull request that adds an AVI extractor. ExoPlayer is also extensible enough such that you could implement an AVI extractor and inject it into the player from your own codebase. In other words, the direct development team are not the only group of people who could add support for this.

@dburckh
Copy link

dburckh commented Oct 31, 2020 via email

@Pentaphon
Copy link

We still need .avi support why is this being ignored

.avi has been largely replaced by .mp4, webm, and even more-so mkv so it makes sense that the devs don't really care about that container anymore. It's up to the community to submit a PR and it has to happen sooner than later because the more time passes, the less people are interested in working on it.

@D00mch
Copy link

D00mch commented Apr 23, 2021

@dburckh , how is it going?

@wubi517
Copy link

wubi517 commented May 11, 2021

I am still waiting avi extractor.

@emouawad
Copy link

Please add AVI support

@kurthuwig
Copy link

Regarding: "AVI will go away and be replaced by MP4": the MP4 container is from the MPEG consortium and only supports MPEG streams. This means that you cannot get other streams in it without conversion. E.g. H.263 video + PCM audio does not work. But that's what most network cameras offer.

@dburckh
Copy link

dburckh commented Jan 22, 2022

My repo with support AVI is available to clone and test out. I've added an option to Misc in the demo to pick any user file off the device.

What is working:

  • Video: H264, MJPEG, XVID (MPEG-4) - Note: MPEG-4 is supported on all devices, but on my Pixel 3a it's only supported at low resolution.
  • Audio: MP3, PCM, AAC. AC3 and DTS should work, are not generally supported by Android. Might work on Android TV

Not working:

  • Video: MP42 (not supported on Android)

Not supported yet:

  • OpenDML - Not supported. Maybe in the future.

https://github.com/dburckh/ExoPlayer

If you find an issue, you can report it and I'll try to fix it. Please have a link available so I can download the file.

@dburckh
Copy link

dburckh commented Jan 22, 2022

Just added MJPEG support updated prior comment. Going to start writing tests!

@moneytoo
Copy link
Contributor

@dburckh Amazing work! Could you please enable Issues section in your GitHub fork so we can discuss issues there? I still need to verify some exception I got but I don't want to spam this thread. Thank you once again!

@dburckh
Copy link

dburckh commented Jan 22, 2022

Done. Make sure you get me a link to a sample.

@kurthuwig
Copy link

Great work! I know two guys that work on an AVI extractor, too. I've sent them a link to your repo. They have some issues but got a very good understanding of the AVI format, so I assume working together would speed things up a lot.

@dburckh
Copy link

dburckh commented Jan 23, 2022

So, the only things I have left on my TODO list are tests and maybe openDML. If there are feature requests or bugs, let me know. I suspect there will be some FourCC variants that I don't have, but those are a quick fix (@moneytoo already found one).

@dburckh
Copy link

dburckh commented Jan 31, 2022

There is a PR up for the ExoPlayer team now. I assume they will request some changes, but hopefully they will accept it in one form or another.

FYI: I changed the branch to "avi"

@dburckh
Copy link

dburckh commented Feb 3, 2022

Google asked me to just put the AVI changes in my first PR, so moved the MJPEG and Demo changes into a branch called "everything" and made it default.

@ojw28
Copy link
Contributor

ojw28 commented Jul 5, 2022

@AquilesCanta has been looking at adding AVI support, and can probably provide an update here.

@AquilesCanta
Copy link
Contributor

AquilesCanta commented Jul 5, 2022

Initial support is ready and will be released soon. But as explained in #9915, support is incomplete and we'll need support from the community to report (and ideally send PRs for) any issues you encounter.

For those, please file fresh issues.

EDIT: AVI support exists in the dev branch.

@google google locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests