Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns don't align properly under all circumstances #43

Open
Wuerfel21 opened this issue Nov 10, 2023 · 5 comments
Open

Columns don't align properly under all circumstances #43

Wuerfel21 opened this issue Nov 10, 2023 · 5 comments
Milestone

Comments

@Wuerfel21
Copy link

Font does not always render properly for me. Seems to depend on family/size/settings used, but is very obnoxious. This is with Radon at size 14, weight 600:
image

Now a normal monospace font (Hack):
image

It also happens on the demo website (all default settings):
image

It doesn't happen for other users I talked to, so it may be an OS issue or something.
I'm using VSCodium 1.84.0 on Kubuntu 23.04

@galdor
Copy link

galdor commented Nov 10, 2023

There are also alignment issues with box characters, for example with this usual test:

  ╔══╦══╗  ┌──┬──┐  ╭──┬──╮  ╭──┬──╮  ┏━━┳━━┓  ┎┒┏┑   ╷  ╻ ┏┯┓ ┌┰┐    ▊ ╱╲╱╲╳╳╳
  ║┌─╨─┐║  │╔═╧═╗│  │╒═╪═╕│  │╓─╁─╖│  ┃┌─╂─┐┃  ┗╃╄┙  ╶┼╴╺╋╸┠┼┨ ┝╋┥    ▋ ╲╱╲╱╳╳╳
  ║│╲ ╱│║  │║   ║│  ││ │ ││  │║ ┃ ║│  ┃│ ╿ │┃  ┍╅╆┓   ╵  ╹ ┗┷┛ └┸┘    ▌ ╱╲╱╲╳╳╳
  ╠╡ ╳ ╞╣  ├╢   ╟┤  ├┼─┼─┼┤  ├╫─╂─╫┤  ┣┿╾┼╼┿┫  ┕┛┖┚     ┌┄┄┐ ╎ ┏┅┅┓ ┋ ▍ ╲╱╲╱╳╳╳
  ║│╱ ╲│║  │║   ║│  ││ │ ││  │║ ┃ ║│  ┃│ ╽ │┃  ░░▒▒▓▓██ ┊  ┆ ╎ ╏  ┇ ┋ ▎
  ║└─╥─┘║  │╚═╤═╝│  │╘═╪═╛│  │╙─╀─╜│  ┃└─╂─┘┃  ░░▒▒▓▓██ ┊  ┆ ╎ ╏  ┇ ┋ ▏
  ╚══╩══╝  └──┴──┘  ╰──┴──╯  ╰──┴──╯  ┗━━┻━━┛           └╌╌┘ ╎ ┗╍╍┛ ┋  ▁▂▃▄▅▆▇█

Tested in Emacs, no problem with other monospace fonts.

@idan
Copy link
Contributor

idan commented Nov 11, 2023

As far as I'm aware, Monaspace doesn't ship box drawing characters, so using them would be forcing the OS's type rasterizer to fall back to "some other font" that contains the needed codepoints, and that other font doesn't share the same metrics as Monaspace.

Doublechecking but I'm pretty sure this is beyond our control short of shipping a bunch of line drawing characters ourselves that fit into our metrics.

@idan idan added the bug label Nov 11, 2023
@idan idan self-assigned this Nov 11, 2023
@idan idan added Investigate and removed bug labels Nov 11, 2023
@Wuerfel21
Copy link
Author

It appears to work properly when using the non-variable version

@Finii
Copy link
Contributor

Finii commented Nov 11, 2023

Nerd Fonts patches box drawing glyph set in ;-D

image

For the box drawing glyphs Monaspace would need to drop its line gap, which other persons found disturbing (Issue 21, 37)

@galdor
Copy link

galdor commented Nov 11, 2023

As far as I'm aware, Monaspace doesn't ship box drawing characters, so using them would be forcing the OS's type rasterizer to fall back to "some other font" that contains the needed codepoints, and that other font doesn't share the same metrics as Monaspace.

Doublechecking but I'm pretty sure this is beyond our control short of shipping a bunch of line drawing characters ourselves that fit into our metrics.

Ah you are 100% right, my bad.

@idan idan removed the investigate label May 1, 2024
@idan idan added this to the 1.3 milestone May 1, 2024
@idan idan removed their assignment May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants