fix: Dynamic set SSM-paramater tier #4613
Conversation
Due to the size of the JIT config returned by github we muse use advanced SSM config
There was a problem hiding this comment.
@ScottGuymer thax for creating. I just checked the multi-runner example in which the x64 linux is using JIT configuration as well. And indeed we are just on the safe side with paramaters from about 4000 bytes.
I would prefer we solve the prbolem in the warpper function in a generic way there were the lambda is sotring pramaters. Initialy we stayed away from adavanced by to avoid costs. As long the paramters are correctly cleared costs should not be a concert. With about 50K of ephemeral runners this should stay under the $5 a month.
Can you also make a note to this (https://github-aws-runners.github.io/terraform-aws-github-runner/configuration/) section that dynamaic generated paramaters are using based on size are stored in the advanced tier. To avoid costs it is important the ssm housekeeper is running, which is enabled by default but can be disabled.
Tested a deployment (multi-runner), the x64 linux runner is using JIT. Thos paramaters got indeed now created as ADVANCED and runners got started.
|
In case parameter size is exceeded the log wil show a log line like: |
|
Updates made, ready for re-review. |
|
Quick test based on multi runner examples: |
fix incorrect merge #4613 Co-authored-by: Scott Guymer <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [6.5.9](v6.5.8...v6.5.9) (2025-06-17) ### Bug Fixes * Dynamic set SSM-paramater tier [#4613](#4613) ([#4622](#4622)) ([430c6e8](430c6e8)) @ScottGuymer * **lambda:** bump the aws group in /lambdas with 6 updates ([ddbe7db](ddbe7db)) * **lambda:** bump the aws-powertools group in /lambdas with 4 updates ([91a06e9](91a06e9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
|
I wish I would have seen this earlier, but I was only looking on the Issues page. 😭 Anyway, after a lot of fumbling around, I found that in AWS you can go into Parameter Store settings and turn on "Intelligent-Tiering" which will automatically make an Advanced Tier parameter if the size is over 4k. |
|
Yeah we also considered using intelligent tiering as an option when setting the value. But one of our team-mates said they had experienced issues with this in the past so we erred on the side of caution and just making it work OOTB. |
Worked for me to get things unblocked. |
GitHub seems to have made a change to encoded_jit_config that has pushed it over the 4kb limit for standard tier of SSM.
We now must always use advanced tier of SSM config for encoded_jit_config.