New vite.config #86
Merged
New vite.config #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new, simplified Vite configuration by removing legacy settings and consolidating plugin usage.
- Removed obsolete plugins and configuration sections (build, define, server, proxy).
- Added new plugins: createIconImportProxy and sparkPlugin within the plugins array.
prichodko
approved these changes
Jun 30, 2025
vite.config.ts
Outdated
| // IMPORTANT NOTE: This file is only used in two situations: local development, and the live preview in Workbench. | ||
| // For deployed Sparks, the `server/main.ts` serves the app itself. Ensure consistency between this file and `server/main.ts` | ||
| // if you have something that needs to available while deployed. | ||
|
|
||
| import tailwindcss from "@tailwindcss/vite"; | ||
| import react from "@vitejs/plugin-react-swc"; | ||
| import { defineConfig, PluginOption } from "vite"; | ||
|
|
||
| import { createLogToFileLogger } from "@github/spark/logToFileLogger"; |
There was a problem hiding this comment.
would be great to change to more usual kebab case fro import paths
There was a problem hiding this comment.
this one actually is a left over but will do fot he rest of the exports 👍
| import { runtimeTelemetryPlugin } from "@github/spark/telemetryPlugin"; | ||
| import sparkAgent from "@github/spark/agent-plugin"; | ||
| import { tagSourcePlugin, designerHost } from "@github/spark/designerPlugin"; | ||
| import sparkPlugin from "@github/spark/spark-vite-plugin"; |
There was a problem hiding this comment.
would prefer import path to be @github/spark/vite
| import { runtimeTelemetryPlugin } from "@github/spark/telemetryPlugin"; | ||
| import sparkAgent from "@github/spark/agent-plugin"; | ||
| import { tagSourcePlugin, designerHost } from "@github/spark/designerPlugin"; | ||
| import sparkPlugin from "@github/spark/spark-vite-plugin"; | ||
| import createIconImportProxy from "@github/spark/vitePhosphorIconProxyPlugin"; |
There was a problem hiding this comment.
can we move this to the spark vite plugin as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.