Rethrow error from ErrorFallback #82
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the error fallback behavior so that, in development mode, errors are rethrown rather than being caught by the error boundary.
- Added a development-only conditional to rethrow errors
- Retains the fallback UI for deployed sparks
| @@ -4,6 +4,10 @@ import { Button } from "./components/ui/button"; | |||
| import { AlertTriangleIcon, RefreshCwIcon } from "lucide-react"; | |||
|
|
|||
| export const ErrorFallback = ({ error, resetErrorBoundary }) => { | |||
There was a problem hiding this comment.
Consider adding explicit TypeScript type definitions for the props (error and resetErrorBoundary) of the ErrorFallback component to improve clarity and maintainability.
Copilot uses AI. Check for mistakes.
nicodes
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this Spark is being edited in development, rethrow the error for it to be caught by the parent container. In deployed sparks, the error boundary will be shown.