🎇 Swap destructured imports from lucide for direct imports per icon #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce vite doesn't tree shake in dev mode and the library is >1mb
There was a problem hiding this comment.
Pull Request Overview
This PR replaces destructured imports from lucide-react with direct icon imports to reduce the development bundle size by avoiding the full 1.23mb file load. Key changes include:
- Updating icon imports in various UI components to directly reference individual icon modules.
- Consolidating the import paths across multiple files to improve development performance.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/ui/sidebar.tsx | Updated PanelLeftIcon to a direct import from lucide-react/dist/esm/icons. |
| src/components/ui/sheet.tsx | Updated XIcon to a direct import from lucide-react/dist/esm/icons. |
| src/components/ui/select.tsx | Replaced destructured imports with direct imports for CheckIcon, ChevronDownIcon, and ChevronUpIcon. |
| src/components/ui/resizable.tsx | Updated GripVerticalIcon import to a direct module. |
| src/components/ui/radio-group.tsx | Changed CircleIcon import to a direct module. |
| src/components/ui/pagination.tsx | Updated imports for ChevronLeftIcon, ChevronRightIcon, and MoreHorizontalIcon to direct imports with semicolon usage. |
| src/components/ui/navigation-menu.tsx | Updated ChevronDownIcon to a direct import. |
| src/components/ui/menubar.tsx | Replaced destructured imports with direct imports for CheckIcon, ChevronRightIcon, and CircleIcon. |
| src/components/ui/input-otp.tsx | Updated MinusIcon import to a direct module. |
| src/components/ui/dropdown-menu.tsx | Changed imports for CheckIcon, ChevronRightIcon, and CircleIcon to direct modules. |
| src/components/ui/dialog.tsx | Updated XIcon import to a direct module. |
| src/components/ui/context-menu.tsx | Replaced destructured imports with direct imports for CheckIcon, ChevronRightIcon, and CircleIcon. |
| src/components/ui/command.tsx | Updated SearchIcon import to a direct module. |
| src/components/ui/checkbox.tsx | Changed CheckIcon import to a direct module. |
| src/components/ui/carousel.tsx | Updated ArrowLeft and ArrowRight imports to direct modules. |
| src/components/ui/calendar.tsx | Updated ChevronLeft and ChevronRight imports to direct modules. |
| src/components/ui/breadcrumb.tsx | Changed imports for ChevronRight and MoreHorizontalIcon to direct modules. |
| src/components/ui/accordion.tsx | Updated ChevronDownIcon import to a direct module. |
wiinci
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the template is using lucide-react icons, which in production is tree shaken. But in dev, they pull the full 1.23mb file, vs ~2kb per icon if they're referenced directly. Updating these references to be direct imports will save almost the entire 1.23mb, is still legible, and does not affect prod bundle size.