Static preview support #80
Open
+42
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for running a static preview of the app by installing a separate supervisor program and automating builds on commit and container start.
- Introduce a new Supervisor program (
spark-static-preview) to serve the latest build vianpm run preview. - Add a
post-commitscript and hook to rebuild the app automatically intopreview-build. - Wire up
post-commitexecution in bothpostStartCommand.shandonCreate.sh.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .devcontainer/spark.conf | Added a Supervisor program for static preview hosting |
| .devcontainer/postStartCommand.sh | Execute the post-commit script once on container start |
| .devcontainer/post-commit | New build script that outputs to the preview directory |
| .devcontainer/onCreate.sh | Set up Git hook and run initial build for static preview support |
Comments suppressed due to low confidence (2)
.devcontainer/onCreate.sh:34
- Ensure
.devcontainer/post-commitis executable before creating the hook. For example, runchmod +x .devcontainer/post-committo avoid permission issues.
ln -fs $(pwd)/.devcontainer/post-commit .git/hooks/post-commit
eljog
commented
Jun 25, 2025
| @@ -2736,6 +2736,28 @@ | |||
| } | |||
| } | |||
| }, | |||
| "node_modules/@rollup/plugin-replace": { | |||
There was a problem hiding this comment.
package-lock.json changes are not introduced by this PR. Must be changes that were left uncommitted in the past revisions
ipc103
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://github.com/github/spark/issues/741
Merge after: https://github.com/github/workbench-sdk/pull/403
Support static preview of the app, by keeping a build for the latest commit running on the default
vite previewport