Chava/replace proxy #79
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces local development proxies with GitHub API endpoints and adds authentication for proxy requests.
- Introduce
GITHUB_API_URLand remove fallback forGITHUB_RUNTIME_PERMANENT_NAME - Add
addGitHubAuthhelper to attachAuthorizationheaders to proxied requests - Update proxy rules: route
/ _spark/llmto GitHub’s models API and wildcard/ _spark/*to GitHub API with path rewrites
Comments suppressed due to low confidence (1)
vite.config.ts:88
- [nitpick] The path rewrite logic is non-trivial; consider adding a comment explaining how
serviceNameis extracted and why the rewrite target uses/runtime/${GITHUB_RUNTIME_PERMANENT_NAME}/${serviceName}.
rewrite: (path) => {
| const extraPlugins: PluginOption[] = []; | ||
|
|
||
| const GITHUB_RUNTIME_PERMANENT_NAME = process.env.GITHUB_RUNTIME_PERMANENT_NAME || process.env.CODESPACE_NAME?.substring(0, 20); | ||
| const GITHUB_RUNTIME_PERMANENT_NAME = process.env.GITHUB_RUNTIME_PERMANENT_NAME |
There was a problem hiding this comment.
Removing the fallback to CODESPACE_NAME may result in undefined runtime paths if the env var is missing. Consider restoring a fallback or explicitly validating and throwing an error when GITHUB_RUNTIME_PERMANENT_NAME isn’t set.
| const GITHUB_RUNTIME_PERMANENT_NAME = process.env.GITHUB_RUNTIME_PERMANENT_NAME | |
| const GITHUB_RUNTIME_PERMANENT_NAME = process.env.GITHUB_RUNTIME_PERMANENT_NAME; | |
| if (!GITHUB_RUNTIME_PERMANENT_NAME) { | |
| throw new Error("Environment variable GITHUB_RUNTIME_PERMANENT_NAME is required but not set."); | |
| } |
Copilot uses AI. Check for mistakes.
| const projectRoot = process.env.PROJECT_ROOT || import.meta.dirname | ||
|
|
||
| const addGitHubAuth = (proxy, options) => { |
There was a problem hiding this comment.
The addGitHubAuth function parameters are untyped. For clarity and future maintenance, add appropriate TypeScript types (for example, proxy: Proxy, options?: ProxyOptions).
Copilot uses AI. Check for mistakes.
No description provided.