Add new shutdown command #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates the devcontainer configuration to use a dedicated shutdown script when the container stops.
- Replaces the previous
deploy.shcommand with a newshutdown.shscript. - Removes the
REVISION_NAMEenvironment variable assignment from the stop hook.
Comments suppressed due to low confidence (2)
.devcontainer/devcontainer.json:15
- [nitpick] Consider updating the repository README or contributing guide to include instructions for the new shutdown hook, so that developers understand when and how it runs.
"onStopCommand": "/usr/local/bin/shutdown.sh"
.devcontainer/devcontainer.json:15
- The previous hook set
REVISION_NAME=spark-previewbefore running the script. Ifshutdown.shstill relies on this environment variable for its logic, it will now fail. Either re-add the assignment or update the script to fetch/deriveREVISION_NAMEinternally.
"onStopCommand": "/usr/local/bin/shutdown.sh"
alexagillman
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.