Enhance get_pull_request_diff tool with pagination and file filtering options #627
+387
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options Signed-off-by: Tiger Kaovilai <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Enhance the get_pull_request_diff tool by adding pagination and file-filtering capabilities to handle large pull requests efficiently.
- Introduces new parameters:
fileList,files,pathPrefix,page, andperPage - Implements paginated list mode and specific-file/path-prefix diff modes
- Updates tests, toolsnap, and README to cover new functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/pullrequests.go | Added imports, parameters, and logic for pagination and filters |
| pkg/github/pullrequests_test.go | Added tests for file list mode with pagination, path prefix, specific files, and full diff |
| pkg/github/toolsnaps/get_pull_request_diff.snap | Updated snapshot to include new input schema properties |
| README.md | Documented new parameters (fileList, files, pathPrefix, page, perPage) |
Comments suppressed due to low confidence (4)
pkg/github/pullrequests.go:1689
- The branch handling
pathPrefixwithoutfileListisn’t covered by tests; add a test case invokingpathPrefixalone to verify correct diff output.
if len(params.Files) > 0 || params.PathPrefix != "" {
pkg/github/pullrequests.go:9
- The code uses json.Marshal in the fileList block but the import for "encoding/json" is missing; add
import "encoding/json".
"strings"
pkg/github/pullrequests.go:1694
- Each call to ListFiles returns a Response with an open body; add
defer resp.Body.Close()inside the loop to avoid leaking HTTP connections.
files, resp, err := client.PullRequests.ListFiles(ctx, params.Owner, params.Repo, int(params.PullNumber), opts)
pkg/github/pullrequests.go:1660
- [nitpick] Filtering by
PathPrefixis duplicated in both the fileList and specific-files branches; consider extracting a reusable helper function.
if params.PathPrefix != "" {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Kaovilai [email protected]
Closes: #625