Skip to content

Don't actually create a PR #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

Don't actually create a PR #589

merged 1 commit into from
Jun 26, 2025

Conversation

SamMorrowDrums
Copy link
Collaborator

Closes:

@Copilot Copilot AI review requested due to automatic review settings June 26, 2025 15:39
@SamMorrowDrums SamMorrowDrums requested a review from a team as a code owner June 26, 2025 15:39
Copy link

👋 Hi there!

It looks like this PR is targeting the main branch. To help maintain our development workflow, please change the base reference to next instead.

If this is a bug fix that requires a patch release __ (e.g., a critical bug that needs to be fixed before the next release), please leave the base branch as main.__

You can change this by:

  1. Clicking the "Edit" button next to the PR title
  2. Changing the base branch from main to next
  3. Clicking "Update pull request"

Thanks for your contribution! 🚀

@SamMorrowDrums SamMorrowDrums merged commit 3deaca8 into main Jun 26, 2025
14 of 16 checks passed
@SamMorrowDrums SamMorrowDrums deleted the release-process-update branch June 26, 2025 15:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes automated pull request creation for branch sync and release, replacing it with manual instructions to comply with organizational policies.

  • Removed the automated PR creation logic in the branch sync workflow and replaced it with manual sync instructions.
  • Replaced the automated release PR creation in the release workflow with tagging and manual PR creation instructions.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/sync-next-branch.yml Replaces automated sync PR creation with manual instructions.
.github/workflows/release.yml Removes automated PR creation for releases and updates release steps.

GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
echo "action-needed=true" >> $GITHUB_OUTPUT
echo "🔄 Next branch needs syncing (${BEHIND_COUNT} commits behind main)"
echo "� Manual PR creation required due to organization policies"
Copy link
Preview

Copilot AI Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '�' character appears to be a mis-encoded or unintended symbol. Replace it with a proper emoji or text to improve clarity.

Suggested change
echo " Manual PR creation required due to organization policies"
echo "⚠️ Manual PR creation required due to organization policies"

Copilot uses AI. Check for mistakes.

echo "5. 🔀 Merge the pull request into main: ${PR_URL}"
echo "6. Post message in #gh-mcp-releases channel in Slack and then share to the other mcp channels"
echo "5. � Create a Pull Request from 'next' to 'main' branch with title 'Release $TAG'"
echo "6. �🔀 Merge the pull request into main"
Copy link
Preview

Copilot AI Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '�' symbol in the instructions seems to be an encoding error. Consider replacing it with a clear and appropriate symbol or text.

Suggested change
echo "6. �🔀 Merge the pull request into main"
echo "5. 🔄 Create a Pull Request from 'next' to 'main' branch with title 'Release $TAG'"
echo "6. 🔀 Merge the pull request into main"

Copilot uses AI. Check for mistakes.

SamMorrowDrums added a commit that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant