Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong possible id-token permissions types listed #33483

Open
1 task done
cmaster11 opened this issue Jun 13, 2024 · 4 comments
Open
1 task done

Wrong possible id-token permissions types listed #33483

cmaster11 opened this issue Jun 13, 2024 · 4 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Comments

@cmaster11
Copy link

cmaster11 commented Jun 13, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

What part(s) of the article would you like to see updated?

In the Defining access for the GITHUB_TOKEN scopes section, the id-token permission is listed with read|write|none, but that permission cannot be set to read.

Trying to do so will produce:

image

Probably you want to list write|none?

I see in https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#understanding-the-oidc-token that it also lists the read permission and a thread that mentions it. Is the read permission available ONLY in specific conditions?

Additional information

No response

@cmaster11 cmaster11 added the content This issue or pull request belongs to the Docs Content team label Jun 13, 2024
Copy link

welcome bot commented Jun 13, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 13, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 13, 2024
@nguyenalex836
Copy link
Contributor

@cmaster11 Thank you for opening this issue! I'll get this triaged for review ✨

@TrickTurner

This comment was marked as spam.

@Sa-su121

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

5 participants
@cmaster11 @nguyenalex836 @TrickTurner @Sa-su121 and others