Skip to content

C++: Move builtin function identification to its own table #19947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2025
Merged

C++: Move builtin function identification to its own table #19947

merged 3 commits into from
Jul 2, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jul 1, 2025 •
edited
Loading

See internal PR for details.

@github-actions github-actions bot added the C++ label Jul 1, 2025
@jketema jketema added the no-change-note-required This PR does not need a change note label Jul 1, 2025
@jketema jketema force-pushed the function-confusion branch from 5db5d8f to 1103644 Compare July 1, 2025 21:38
@jketema jketema marked this pull request as ready for review July 2, 2025 06:37
@Copilot Copilot AI review requested due to automatic review settings July 2, 2025 06:37
@jketema jketema requested a review from a team as a code owner July 2, 2025 06:37
Copilot
Copilot AI reviewed Jul 2, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

IdrissRio
IdrissRio approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@IdrissRio IdrissRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jketema jketema merged commit e47f16b into github:main Jul 2, 2025
14 of 17 checks passed
@jketema jketema deleted the function-confusion branch July 2, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@IdrissRio IdrissRio IdrissRio approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @IdrissRio